Use DiffID instead of ID in config.md #299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
On Mon, Sep 12, 2016 at 07:53:31PM -0700, Lei Jitang wrote:
49f72a9 looks good to me. |
Member
|
LGTM |
coolljt0725
force-pushed
the
diffid
branch
2 times, most recently
from
2308047 to
269f9a7
Compare
Signed-off-by: Lei Jitang <[email protected]>
coolljt0725
changed the title
Contributor
|
Added to #333 which is a v1.0.0-rc1 release blocker. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We doesn't define
layer ID, to avoid confusingusers, this should be a
DiffID.Signed-off-by: Lei Jitang [email protected]